Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API routes to get runner registration token #27144

Merged
merged 22 commits into from
Dec 27, 2023
Merged

Add API routes to get runner registration token #27144

merged 22 commits into from
Dec 27, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 20, 2023 •
edited by delvh
Loading

Replace #23761

@lunny lunny added modifies/api This PR adds API routes or modifies them topic/gitea-actions related to the actions of Gitea labels Sep 20, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2023
@lunny lunny added this to the 1.21.0 milestone Sep 20, 2023
@lunny lunny modified the milestones: 1.21.0, 1.22.0 Sep 21, 2023
denyskon
denyskon reviewed Sep 21, 2023
View reviewed changes
routers/api/v1/admin/runners.go Outdated Show resolved Hide resolved
routers/api/v1/org/runners.go Outdated Show resolved Hide resolved
routers/api/v1/repo/runners.go Outdated Show resolved Hide resolved
@denyskon
Copy link
Member

@lunny CI failure seems related

@lunny
Copy link
Member Author

lunny commented Sep 28, 2023

@lunny CI failure seems related

Fixed

@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 5, 2023
@delvh delvh added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Oct 16, 2023
@denyskon denyskon self-requested a review October 19, 2023 14:15
@denyskon denyskon added the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Oct 19, 2023
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Oct 19, 2023
@denyskon denyskon removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 19, 2023
@denyskon
Copy link
Member

Removing backport as it's a new feature and we're in feature freeze

@denyskon
Copy link
Member

@lunny Seems that you have to run make generate-swagger again, and also add the repo runner endpoint inside api.go

@lunny lunny changed the title Add get actions runner registration token for API routes, repo, org and global level Add get actions runner registration token for API routes, repo, org, user and global level Oct 30, 2023
denyskon
denyskon approved these changes Oct 30, 2023
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2023
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 27, 2023
@lunny lunny enabled auto-merge (squash) December 27, 2023 07:26
@lunny lunny merged commit baf0d40 into go-gitea:main Dec 27, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 27, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 29, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
adc078e 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  switch destination directory for apt signing keys (go-gitea#28639)
  Extend description for ARTIFACT_RETENTION_DAYS (go-gitea#28626)
  Refactor timeutil package (go-gitea#28623)
  Refactor some legacy code and remove unused code (go-gitea#28622)
  Remove unnecessary syncbranchToDB with tests (go-gitea#28624)
  Do not set `Accept` header twice (go-gitea#28598)
  [skip ci] Updated translations via Crowdin
  fix wrong link in user and organization profile when using relative url (go-gitea#28617)
  Add get actions runner registration token for API routes, repo, org, user and global level (go-gitea#27144)
  Fix session key conflict with database keyword (go-gitea#28613)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @denyskon
@techknowlogick @fuxiaohei
Add get actions runner registration token for API routes, repo, org, …
882efb8 
…user and global level (go-gitea#27144)

Replace go-gitea#23761

---------

Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@lunny lunny deleted the lunny/api_registration_token branch January 27, 2024 09:07
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @denyskon
@techknowlogick @silverwind
Add get actions runner registration token for API routes, repo, org, …
b043436 
…user and global level (go-gitea#27144)

Replace go-gitea#23761

---------

Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
@delvh delvh changed the title Add get actions runner registration token for API routes, repo, org, user and global level Add API routes to get actions runner registration token for repos, orgs, users and globally Apr 7, 2024
@delvh delvh changed the title Add API routes to get actions runner registration token for repos, orgs, users and globally Add API routes to get runner registration token Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 left review comments

@denyskon denyskon denyskon approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @denyskon @wolfogre @puni9869 @GiteaBot @delvh @techknowlogick