Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing deps to files-changed, downgrade markdownlint-cli #27100

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Add missing deps to files-changed, downgrade markdownlint-cli #27100

merged 4 commits into from
Sep 16, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 16, 2023 •
edited
Loading

The docs and yaml actions categories need to run when the dependencies markdownlin-cli or yamllint change, so add those to the list of dependencies for these actions.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 16, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2023
@silverwind
Copy link
Member Author

silverwind commented Sep 16, 2023 •
edited
Loading

Also includes a downgrade to markdownlint-cli to work around #27098.

@silverwind silverwind mentioned this pull request Sep 16, 2023
Closed
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2023
@puni9869
Copy link
Member

puni9869 commented Sep 16, 2023 •
edited
Loading

No blocker once linter is fix. Execute
@CaiCandong Please do to rituals for approving the PR

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 16, 2023
@silverwind silverwind enabled auto-merge (squash) September 16, 2023 12:48
@silverwind
Copy link
Member Author

Merging this now to unblock CI.

@puni9869
Copy link
Member

Thanks @silverwind for the quick support on this fix

@silverwind silverwind changed the title Add missing deps to files-changed Add missing deps to files-changed, downgrade markdownlint-cli Sep 16, 2023
@silverwind
Copy link
Member Author

Likely causes in markdownlint:

DavidAnson/markdownlint@a736588
DavidAnson/markdownlint@1ddee6b

@puni9869 puni9869 added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Sep 16, 2023
delvh
delvh reviewed Sep 16, 2023
View reviewed changes
.github/workflows/files-changed.yml
Comment on lines +67 to +68
- "package.json"
- "package-lock.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those two are a bit weird for the docs category.
If I see that correctly, it'll mean that any JS dependency update or new JS feature will be marked as kind/docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add or remove the kind/docs

Copy link
Member Author

@silverwind silverwind Sep 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the labels config, this is the actions config. mardownlint-cli version is defined in these files, if those change we need to run the docs workflow to confirm the lnting still works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

@silverwind silverwind merged commit 5fc2a3f into go-gitea:main Sep 16, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 16, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 16, 2023
@silverwind silverwind deleted the deps-deps branch September 16, 2023 13:37
@delvh delvh removed this from the 1.22.0 milestone Sep 16, 2023
@delvh delvh added this to the 1.21.0 milestone Sep 16, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 17, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
1434f7a 
* giteaoffical/main: (23 commits)
  Search branches (go-gitea#27055)
  Fix wrong migration for email address (go-gitea#27106)
  [skip ci] Updated translations via Crowdin
  Support `.git-blame-ignore-revs` file (go-gitea#26395)
  Add `RemoteAddress` to mirrors (go-gitea#26952)
  Upgrading the actions/checkout@4 (go-gitea#27096)
  Next round of `db.DefaultContext` refactor (go-gitea#27089)
  Ui correction in mobile view nav bar left aligned items. (go-gitea#27046)
  Add missing deps to files-changed (go-gitea#27100)
  Use db.WithTx for AddTeamMember to avoid ctx abuse (go-gitea#27095)
  Drop Node.js 16 and update js dependencies (go-gitea#27094)
  Fix NPE when editing OAuth2 applications (go-gitea#27078)
  Use `print` instead of `printf` (go-gitea#27093)
  Add tests for db indexer in indexer_test.go (go-gitea#27087)
  [skip ci] Updated translations via Crowdin
  Allow empty Conan files (go-gitea#27092)
  Actions are no longer experimental, so enable them by default (go-gitea#27054)
  Update brew installation documentation since gitea moved to brew core package (go-gitea#27070)
  More refactoring of `db.DefaultContext` (go-gitea#27083)
  [skip ci] Updated translations via Crowdin
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Sep 17, 2023
@silverwind
Merge remote-tracking branch 'origin/main' into usefetch
8a6e43c 
* origin/main: (53 commits)
  Search branches (go-gitea#27055)
  Fix wrong migration for email address (go-gitea#27106)
  [skip ci] Updated translations via Crowdin
  Support `.git-blame-ignore-revs` file (go-gitea#26395)
  Add `RemoteAddress` to mirrors (go-gitea#26952)
  Upgrading the actions/checkout@4 (go-gitea#27096)
  Next round of `db.DefaultContext` refactor (go-gitea#27089)
  Ui correction in mobile view nav bar left aligned items. (go-gitea#27046)
  Add missing deps to files-changed (go-gitea#27100)
  Use db.WithTx for AddTeamMember to avoid ctx abuse (go-gitea#27095)
  Drop Node.js 16 and update js dependencies (go-gitea#27094)
  Fix NPE when editing OAuth2 applications (go-gitea#27078)
  Use `print` instead of `printf` (go-gitea#27093)
  Add tests for db indexer in indexer_test.go (go-gitea#27087)
  [skip ci] Updated translations via Crowdin
  Allow empty Conan files (go-gitea#27092)
  Actions are no longer experimental, so enable them by default (go-gitea#27054)
  Update brew installation documentation since gitea moved to brew core package (go-gitea#27070)
  More refactoring of `db.DefaultContext` (go-gitea#27083)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh left review comments

@CaiCandong CaiCandong CaiCandong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @puni9869 @CaiCandong @delvh @GiteaBot