Skip to content

Conversation

@delvh
Copy link
Member

@delvh delvh commented Aug 28, 2023

Corollary to #26775:
All selectors I found that are actually used and not necessarily present in the current code have been copied to web_src/css/base.css.
Everything else should be a clean removal.

@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 28, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2023
@silverwind
Copy link
Member

silverwind commented Aug 28, 2023

We can potentially drop the !important from the .text.red classes etc, but it might have a side-effect or two.

@delvh
Copy link
Member Author

delvh commented Aug 28, 2023

Let's leave that for follow-up PRs…

@silverwind
Copy link
Member

silverwind commented Aug 28, 2023

It'll likely be no issue, 2 classes is heavier than many things. But yes, we can do this another time, let's not forget it.

Edit: On second thought, let's keep important for now. I forsee some issues with the deeply nested repo selectors for example.

@delvh
Copy link
Member Author

delvh commented Aug 30, 2023

@wxiaoguang please re-review.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 30, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 30, 2023
@silverwind silverwind enabled auto-merge (squash) August 30, 2023 10:30
@silverwind silverwind merged commit 2590707 into go-gitea:main Aug 30, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Aug 30, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 30, 2023
@delvh delvh deleted the remove-fomantic-text-module branch October 19, 2023 20:37
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants