Fix incorrect replacement in markdown image links

[CaiCandong]

Fix #26548
When the repo name is src:

• /<user>/src/src/branch/ => /<user>/media/src/branch/

it should be:

• /<user>/src/src/branch/ => /<user>/src/media/branch/

[puni9869]

Please also check: if we are not inserting the image link into DB. <--- Less probable situation.

[CaiCandong]

Please also check: if we are not inserting the image link into DB. <--- Less probable situation.

ok , but I'm puzzled about this unit test case that didn't pass

[puni9869]

Please also check: if we are not inserting the image link into DB. <--- Less probable situation.

ok , but I'm puzzled about this unit test case that didn't pass

Your unit test cases are failing, you changed the path of image so you need to change in the unit test cases.
I am wondering, it should not affect in older versions of gitea.

https://github.com/go-gitea/gitea/actions/runs/5887628224/job/15967326590?pr=26562#step:8:112

[CaiCandong]

Your unit test cases are failing, you changed the path of image so you need to change in the unit test cases.
I am wondering, it should not affect in older versions of gitea.

I am confused about this test case. For both test cases, the rendering before and after my changes in the page display is consistent:

• <img src="Link"> => http://localhost:3000/caicandong/wire-examples/media/branch/main/Link
• <img src="./icon.png">=>http://localhost:3000/caicandong/wire-examples/media/branch/main/icon.png

[puni9869]

Your unit test cases are failing, you changed the path of image so you need to change in the unit test cases.
I am wondering, it should not affect in older versions of gitea.

I am confused about this test case. For both test cases, the rendering before and after my changes in the page display is consistent:

• <img src="Link"> => http://localhost:3000/caicandong/wire-examples/media/branch/main/Link
• <img src="./icon.png">=>http://localhost:3000/caicandong/wire-examples/media/branch/main/icon.png

Can you push your code. I can take a look.

[yp05327]

At first, I also considered to add /branch/, but it seems that we do not only have /branch behind /media/:

gitea/routers/web/web.go

Lines 1312 to 1319 in c6b92c8

	m.Group("/media", func() {
	m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.SingleDownloadOrLFS)
	m.Get("/tag/*", context.RepoRefByType(context.RepoRefTag), repo.SingleDownloadOrLFS)
	m.Get("/commit/*", context.RepoRefByType(context.RepoRefCommit), repo.SingleDownloadOrLFS)
	m.Get("/blob/{sha}", context.RepoRefByType(context.RepoRefBlob), repo.DownloadByIDOrLFS)
	// "/*" route is deprecated, and kept for backward compatibility
	m.Get("/*", context.RepoRefByType(context.RepoRefLegacy), repo.SingleDownloadOrLFS)
	}, repo.MustBeNotEmpty, reqRepoCodeReader)

Is it ok that just support /branch here?
Maybe CI failure is related to this problem.

So maybe we need to combine the url instead of replace /src/?

[CaiCandong]

Is it ok that just support /branch here?

That's not my concern, I do think there's something wrong with this test case. For the current gitea it is actually the rendered result below.

• <img src="Link"> => http://localhost:3000/caicandong/wire-examples/media/branch/main/Link
• <img src="./icon.png">=>http://localhost:3000/caicandong/wire-examples/media/branch/main/icon.png
  And the test case is:
• <img src="Link"> => http://localhost:3000/caicandong/wire-examples/media/main/Link
• <img src="./icon.png">=>http://localhost:3000/caicandong/wire-examples/media/main/icon.png

[puni9869]

expected: "<img src=\"http://localhost:3000/gogits/gogs/media/master/Link\"/>"
        	            	actual  : "<img src=\"http://localhost:3000/gogits/gogs/src/master/Link\"/>"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-<img src="http://localhost:3000/gogits/gogs/media/master/Link"/>
        	            	+<img src="http://localhost:3000/gogits/gogs/src/master/Link"/>
        	Test:       	TestRender_RelativeImages
    html_test.go:475: 
        	Error Trace:	/home/runner/work/gitea/gitea/modules/markup/html_test.go:475
        	            				/home/runner/work/gitea/gitea/modules/markup/html_test.go:494
        	Error:      	Not equal: 
        	            	expected: "<img src=\"http://localhost:3000/gogits/gogs/media/master/icon.png\"/>"
        	            	actual  : "<img src=\"http://localhost:3000/gogits/gogs/src/master/icon.png\"/>"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-<img src="http://localhost:3000/gogits/gogs/media/master/icon.png"/>
        	            	+<img src="http://localhost:3000/gogits/gogs/src/master/icon.png"/>
        	Test:       	TestRender_RelativeImages

The path that is forming in the test case is wrong. Still src is coming in the path.

[puni9869]

Check line

in html_test.go
Similarly at other failing test cases too.

[CaiCandong]

What I mean is that there is something wrong with this test case, the expected results are not the same as what I see on the gitea page. @puni9869 @yp05327
https://try.gitea.io/CaiCandong/abc/src/branch/main/README.md

[yp05327]

// "/*" route is deprecated, and kept for backward compatibility

It seems that in old version the media link is /media/<branchname>
but now it is /media/branch/<branchname>

[yp05327]

I see why this fix is not good.
As I have mentioned in #26562 (comment)
If you select to a tag or commit, the media link will become /media/tag/<TagName>

for example:
https://try.gitea.io/yp05327/testrepo/src/tag/testtag222

[CaiCandong]

I see why this fix is not good.

I'm not saying that my current solution is right, I think we need to address this outdated test case first and then consider a good solution.

[KN4CK3R]

There are other places which replace /src/ with /raw/ for example which will fail too. The whole string replacing solution is buggy.

[silverwind]

Maybe split string on /, replace at n-th position, then re-join.

[CaiCandong]

No good solution for now, this bug only affects users or repositories with the name src.

[puni9869]

No worries, You have tried , Appreciated for the great efforts.

[KN4CK3R]

I will post another solution.

[KN4CK3R]

Added a fix with #26745