maintain aspect ratio for auth icons #26488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When specifying an icon URL for a authentication source, it's forced to be an width and height of 20px. However this didn't take into account that icons could have an different aspect ratio of 1:1. - This patch fixes that by instead using `max-width` and `max-height` which will respect other aspect ratios. - Resolves https://codeberg.org/forgejo/forgejo/issues/1234 Refs: https://codeberg.org/forgejo/forgejo/pulls/1241 (cherry picked from commit bd915b867057c1aaae1b4a33a83a5703cabda462)
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
|
This change is not right. For example, a SVG with width=16 and height=16 I will fix it by a correct approach. |
|
Likely needs CSS |
|
Yup, the "object-fit" is a right approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max-widthandmax-heightwhich will respect other aspect ratios.Refs: https://codeberg.org/forgejo/forgejo/pulls/1241
(cherry picked from commit bd915b867057c1aaae1b4a33a83a5703cabda462)