Don't show Followers / Following if both equal to zero

[n0toose]

• This setting will not affect instances not running in prod mode.
• This optimization aims to alleviate the "gamification" phenomenon
  present in other big platforms, while not compromising the social
  features of Gitea in any capacity.

[n0toose]

Screenshots

[yp05327]

Maybe we can also remove the link if there's no followers or no following.

[n0toose]

Maybe we can also remove the link if there's no followers or no following.

"the link" as in https://instance/user/followers, or do you want me to reinstate the "0 Followers" indicator and just make it so that it doesn't point anywhere?

[wxiaoguang]

TBH I am not a fan of toggling the UI elements too much.

The questions are:

1. Does the "0 followers" text really affect users or does it have any side effect?
2. If an element is hidden, during development/refactoring, such element would be broken because developers won't notice it (the "users" in development instance usually don't have followers)

[n0toose]

Does the "0 followers" text really affect users or does it have any side effect?

It is my opinion that it is unhealthy to "throw" people straight into a social media-like numbers game - without trying to downplay the importance of the existence of those features. I think it's one of the weakest points of the "GitHub model" - I find that it is distracting and counter-productive, both in the context of open-source and in a hypothetical, more "serious" business environment. From a purely aesthetic point of view, I could say that it is redundant.

Of course, this can't be measured.

If an element is hidden, during development/refactoring, such element would be broken because developers won't notice it (the "users" in development instance usually don't have followers)

We could use the RUN_MODE variable to establish this.

[silverwind]

FWIW, this behaviour is consistent with GitHub, so I'm okay with it. Just would like to see the mode dependency removed as well.

[yp05327]

Maybe we can also remove the link if there's no followers or no following.

"the link" as in https://instance/user/followers, or do you want me to reinstate the "0 Followers" indicator and just make it so that it doesn't point anywhere?

I mean in this case:

You can also click 0 Following and then get an empty page like:

So, maybe we can remove this link (make it unclickable) when there's no followers or no following.

[n0toose]

Keep in mind that this makes the person icon unclickable in some arbitrary cases, and clickable in some others. I think I'll remove the "clickability" (oh hey, new word!) entirely.

[silverwind]

I think we can simplify the template significantly with a CSS pseudo element, only needs a class on the parent to be able to select it:

.follow-links a + a:before {
  content: " · ";
}

Then, just render the <a> with simple {{if .NumFollowers}} conditions.

[lunny]

Since there are no more interesting to hide the numbers, I think we can close this.