Fix doubled issue tab introduced in migration v16 #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are existing at the same time Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
Signed-off-by: David Schneiderbauer <dschneiderbauer@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
======================================
Coverage 27.3% 27.3%
======================================
Files 86 86
Lines 17139 17139
======================================
Hits 4680 4680
Misses 11781 11781
Partials 678 678Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lafriks
requested changes
Sep 27, 2017
models/migrations/v44.go
Outdated
| ) | ||
|
|
||
| var externalIssueRepos []Repo | ||
| err := x.Table("repository").Select("`repository`.id"). |
There was a problem hiding this comment.
No need for repository table here. Just select form repo_unit directly
models/migrations/v44.go
Outdated
| } | ||
|
|
||
| var externalWikiRepos []Repo | ||
| err = x.Table("repository").Select("`repository`.id"). |
|
@lafriks Included your requested changes |
lafriks
approved these changes
Sep 27, 2017
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM :) |
|
LGTM |
tboerger
added
lgtm/done
|
Make LG-TM work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration v16 creates UnitTypeIssue and UnitTypeExternalTracker for each repository with enabled external issue tracker as repo.EnableIssues is true even for external tracker.
And because both Unit Types exist the issue tab is shown twice.
The same behaviour is happening to UnitTypeWiki and UnitTypeExternalWiki, but because the tab is not changed in view it has no visual impact.
PR fixes both mistakes and removes UnitTypeIssue for repositories with UniTypeExternalTracker and removes UnitTypeWiki for repositories with UnitTypeExternalWiki.