-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus-ify #26051
Docusaurus-ify #26051
Conversation
Why WIP? |
Another thing to note, we no longer have an "offline build" of docs with this current PR, as there's no hugo anymore. Does it make sense to add docusaurus scaffolding in this PR, a follow-up, or not at all? |
follow-up? |
Still, why is this PR WIP? |
Only until I fixed the CI piece and got a little feedback. It is otherwise ready, simply needs coordination among the three PRs because the docs repo PR will fail until they are all merged, and then that one can be merged. Not so much WIP as it is coordinated. |
My thoughts on an offline build: I know people have found it helpful in the past so I'm hesitant to do away with it, at least fully, but I'd be resistant to including docusaurus deps into the main repo. Perhaps the offline build could remain in some minimal way of rendering the markdown to HTML? |
That could be possible, what I've done in this specific PR is to just tar up the markdown files, so at least they are included. A followup could be to convert them to HTML maybe? Or would you prefer that happen in this PR? |
probably a followup, as this covers a lot already (thanks btw) |
Is there a matching PR for the docs repo for when this is merged? |
|
We can have a HTML tar or PDF download link on the documentation site. |
@@ -879,20 +878,14 @@ release-sources: | $(DIST_DIRS) | |||
|
|||
.PHONY: release-docs | |||
release-docs: | $(DIST_DIRS) docs | |||
tar -czf $(DIST)/release/gitea-docs-$(VERSION).tar.gz -C ./docs/public . | |||
tar -czf $(DIST)/release/gitea-docs-$(VERSION).tar.gz -C ./docs . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is docs source but not the docs. It's a break change from before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that breaking?
For whom?
People who self-host our documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned above, a follow-up could be to add some form of conversion to HTML/PDF or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
61c9e7e
to
9ceca9a
Compare
See #26051 --------- Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: JonRB <4564448+eeyrjmr@users.noreply.github.com>
See #26051 --------- Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
@jolheiser please fix the merge conflicts. 🍵 |
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Then, wonder how to view preview when edit document now? |
This is something I will look in to, but I'd argue that previewing it in Hugo wouldn't be a good measure of how it would end up in docusaurus. For now any markdown previewer should give a semi-accurate view until we get something better in place. 🙂 |
* giteaofficial/main: (21 commits) Only show newly pushed branches message in the same repository (go-gitea#26148) Docusaurus-ify (go-gitea#26051) Display deprecated warning in admin panel pages as well as in the log file (go-gitea#26094) Remove "misc" scope check from public API endpoints (go-gitea#26134) Fix LFS object list style (go-gitea#26133) Drop the correct deleted branch table (go-gitea#26028) Fix CLI allowing creation of access tokens with existing name (go-gitea#26071) Fix incorrect router logger (go-gitea#26137) Increase table cell horizontal padding (go-gitea#26140) Update xorm version (go-gitea#26128) Fix UI for release tag page / wiki page / subscription page (go-gitea#25948) added ssh mirror workaround description (go-gitea#26096) Improve "gitea doctor" sub-command and fix "help" commands (go-gitea#26072) Fix wrong commit status in web ui (go-gitea#26121) remove IsWarning in tmpl (go-gitea#26120) Fix minor capitalization error in string (go-gitea#26100) Improve commit graph alignment and truncating (go-gitea#26112) Fix wrong workflow status when rerun a job in an already finished workflow (go-gitea#26119) Allow Organisations to have a E-Mail (go-gitea#25082) doc sync authentication.md to zh-cn (go-gitea#26117) ...
#26051 I accidentally rebased locally without my re-addition for these files, so they were missed in the merge, but only for `main`. Signed-off-by: jolheiser <john.olheiser@gmail.com>
This PR cleans up the docs in a way to make them simpler to ingest by our docs repo.
@variable@
style, simply for easier sed invocations when required.Sorry if I rebase a few times in these PRs, it tends to be easier to deal with conflicts since there's a lot of file moving as well.