-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-line comment support in api #25523
base: main
Are you sure you want to change the base?
Conversation
first step of go-gitea#12640 - add `side` and `line` to replace `new/old_position` in api like github - add `start_line` in api like github for `multi-line comment` creating - for multi-line comment, will cut all lines in range [start_line, line] for patch generate, then user can view all lines in this range on commnet list ui. - not suport `start_side` now, `line` and `start_line` should in same side todos: - [ ] suport creating multi-line comments by ui & incomming mail - [ ] more ui updates Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 Could you resolve conflicts? |
I have architectural objections to this PR: There is a reason why I recommended a one-way multiline comment that only stores a relative counter. |
why need four lines? do you means in database? now only add two new colums named as then, not support |
I guess what delvh wants to say is that instead of adding |
first step of #12640
add
side
andline
to replacenew/old_position
in api like githubadd
start_line
in api like github formulti-line comment
creatingfor multi-line comment, will cut all lines in range [start_line, line] for patch generate, then user can view all lines in this range on commnet list ui. example:
not suport
start_side
now,line
andstart_line
should in same sidetodos: