Skip to content

Ctrl + Enter to submit forms #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 22, 2017
Merged

Ctrl + Enter to submit forms #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
09f817c
Hotfix for "Add time manually" (https://github.com/go-gitea/gitea/pul…
jonasfranz Sep 13, 2017
b3fd467
Merge branch 'master' of https://github.com/go-gitea/gitea
jonasfranz Sep 13, 2017
af85943
Merge branch 'master' of https://github.com/go-gitea/gitea
jonasfranz Sep 17, 2017
6c9abba
Merge branch 'master' of https://github.com/go-gitea/gitea
jonasfranz Sep 18, 2017
f3454d7
Submit forms if Ctrl+Enter is pressed inside a textarea
jonasfranz Sep 18, 2017
e7edb4c
Adding separate class for Ctrl+Enter-Submit
jonasfranz Sep 18, 2017
704f4b8
Merge branch 'master' into ctrl-enter-to-submit
andreynering Sep 20, 2017
273acc1
Merge branch 'master' into ctrl-enter-to-submit
lafriks Sep 20, 2017
b4c8843
Merge branch 'master' into ctrl-enter-to-submit
lafriks Sep 21, 2017
7391927
Changing .ctrlenter to .js-quick-submit
jonasfranz Sep 21, 2017
524541e
Merge branch 'master' into ctrl-enter-to-submit
lunny Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions public/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,6 +1579,7 @@ $(document).ready(function () {
initCodeView();
initVueApp();
initTeamSettings();
initCtrlEnterSubmit();

// Repo clone url.
if ($('#repo-clone-url').length > 0) {
Expand Down Expand Up @@ -1786,6 +1787,14 @@ function initVueComponents(){
})
}

function initCtrlEnterSubmit() {
$(".js-quick-submit").keydown(function(e) {
if (((e.ctrlKey && !e.altKey) || e.metaKey) && (e.keyCode == 13 || e.keyCode == 10)) {
$(this).closest("form").submit();
}
});
}

function initVueApp() {
var el = document.getElementById('app');
if (!el) {
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/comment_tab.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<a class="item" data-tab="preview" data-url="{{AppSubUrl}}/api/v1/markdown" data-context="{{.RepoLink}}">{{.i18n.Tr "repo.release.preview"}}</a>
</div>
<div class="ui bottom attached active tab segment" data-tab="write">
<textarea id="content" class="edit_area" name="content" tabindex="4" data-id="issue-{{.RepoName}}" data-url="{{AppSubUrl}}/api/v1/markdown" data-context="{{.Repo.RepoLink}}">
<textarea id="content" class="edit_area js-quick-submit" name="content" tabindex="4" data-id="issue-{{.RepoName}}" data-url="{{AppSubUrl}}/api/v1/markdown" data-context="{{.Repo.RepoLink}}">
{{if .IssueTemplate}}{{.IssueTemplate}}{{else if .PullRequestTemplate}}{{.PullRequestTemplate}}{{else}}{{.content}}{{end}}</textarea>
</div>
<div class="ui bottom attached tab segment markdown" data-tab="preview">
Expand Down