Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bucket name to s3 drone plugin #2505

Merged
merged 3 commits into from
Sep 15, 2017
Merged

Added bucket name to s3 drone plugin #2505

merged 3 commits into from
Sep 15, 2017

Conversation

tboerger
Copy link
Member

No description provided.

@lafriks
Copy link
Member

lafriks commented Sep 14, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 14, 2017
@lafriks lafriks added this to the 1.3.0 milestone Sep 14, 2017
@appleboy
Copy link
Member

appleboy commented Sep 14, 2017 •
edited by tboerger
Loading

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2017
@codecov-io
Copy link

codecov-io commented Sep 14, 2017 •
edited
Loading

Codecov Report

Merging #2505 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2505   +/-   ##
======================================
  Coverage    27.7%   27.7%           
======================================
  Files          83      83           
  Lines       16914   16914           
======================================
  Hits         4686    4686           
  Misses      11553   11553           
  Partials      675     675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9e20b...fe0b524. Read the comment docs.

@jonasfranz
Copy link
Member

Test fails after master rebase.

@tboerger
Copy link
Member Author

But failing tests are not related to this change

@lunny
Copy link
Member

lunny commented Sep 15, 2017

@tboerger yes. #2516 maybe fix that.

@lunny lunny merged commit cbe5058 into go-gitea:master Sep 15, 2017
@tboerger tboerger deleted the fix-drone branch September 15, 2017 06:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tboerger @lafriks @appleboy @codecov-io @jonasfranz @lunny