-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge new project
templates into one
#24985
Merged
silverwind
merged 9 commits into
go-gitea:main
from
delvh:refactor/merge-new-project-templates
May 31, 2023
Merged
Merge new project
templates into one
#24985
silverwind
merged 9 commits into
go-gitea:main
from
delvh:refactor/merge-new-project-templates
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally simplify the "new project" template slightly
delvh
added
topic/ui
Change the appearance of the Gitea UI
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
labels
May 29, 2023
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 29, 2023
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
May 29, 2023
delvh
changed the title
Merge
WIP: Merge May 29, 2023
new project
templates into onenew project
templates into one
delvh
changed the title
WIP: Merge
Merge May 29, 2023
new project
templates into onenew project
templates into one
silverwind
reviewed
May 29, 2023
lunny
reviewed
May 29, 2023
@lunny @silverwind all done. |
silverwind
approved these changes
May 29, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 29, 2023
silverwind
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
May 29, 2023
😲 I just noticed I can remove a lot of dead code. |
According to my quick calculation, this PR reduces Giteas binary and RAM size by roughly |
wxiaoguang
approved these changes
May 31, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 31, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 31, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 31, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 1, 2023
* upstream/main: Fix users cannot visit issue attachment bug (go-gitea#25019) Fix incorrect issuel filter menu style (go-gitea#25018) Update repo's default branch when adding new files in an empty one (go-gitea#25017) Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (go-gitea#24988) Merge `new project` templates into one (go-gitea#24985) Add chinese documentations for `cran package registry` (go-gitea#25012)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
topic/ui
Change the appearance of the Gitea UI
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally simplify the
new project
template slightly.Review hint: Disable whitespace changes.
Before
New repo project
Edit repo project
New user/org project
Edit user/org project
After
New repo project
Edit repo project
New user/org project
Edit user/org project