Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only validate changed columns when update user (#24867) #24903

Merged
merged 2 commits into from
May 24, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #24867 by @lunny

Fix #23211
Replace #23496

@GiteaBot GiteaBot added this to the 1.19.4 milestone May 24, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 24, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2023
@yp05327
Copy link
Contributor

yp05327 commented May 24, 2023

Ah, fmt is not imported in models/user/user_test.go
image

ps: Is it possible to fix import error automatically by @GiteaBot

@lunny lunny enabled auto-merge (squash) May 24, 2023 07:53
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
@lunny lunny merged commit 275abd6 into go-gitea:release/v1.19 May 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jun 3, 2023
…itea#24903)

Backport go-gitea#24867 by @lunny

Fix go-gitea#23211
Replace go-gitea#23496

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
(cherry picked from commit 275abd6)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 22, 2023
@techknowlogick techknowlogick deleted the backport-24867-v1.19 branch September 9, 2023 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants