Fix Actions being enabled accidentally (#24802) #24810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24802 by @wolfogre
Regression of #24536. If the user doesn't explicitly disable Actions, it will be enabled.
loadRepositoryFrombeforeloadActionsFrom.gitea/modules/setting/setting.go
Lines 234 to 237 in 25d4f95
loadRepositoryFrom,rootCfg.Section("actions").Key("ENABLED").MustBool(true)will setactions.ENABLEDwithtrue.gitea/modules/setting/repository.go
Lines 313 to 315 in 25d4f95
loadActionsFrom,rootCfg.Section("actions")will get a section with Actions enabled.gitea/modules/setting/actions.go
Lines 23 to 26 in 25d4f95
Although the cause of the problem was using
trueby copy-paste mistake, it also surprised me thatrootCfg.Section("actions").Key("ENABLED").MustBool(true)doesn't only read, but also write.