Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable for PR approver token #24798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corytodd
Copy link
Contributor

@corytodd corytodd commented May 18, 2023

Allow customization of the git trailer token used to annotate approvers when generating the default merge message for pull requests. Also simplify the logic that writes the trailer string for each reviewer.

fixes #24797

With default ini
image

With custom APPROVER_TRAILER_TOKEN in ini
image

Allow customization of the git trailer token used to annotate approvers
when generating the default merge message for pull requests. Also 
simplify the logic that writes the trailer string for each reviewer.

Signed-off-by: Cory Todd <cory.todd@canonical.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 18, 2023
@a1012112796
Copy link
Member

I think it would be fun to make it configable for each repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Reviewed-by trailer token a configurable option
3 participants