Skip to content

Fix redis unit check to test if CI #24643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kdumontnu
Copy link
Contributor

Currently, unit tests fail for me locally (eg. make test-backend).

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2023
@kdumontnu kdumontnu requested a review from wxiaoguang May 10, 2023 20:22
@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 10, 2023

I would suggest not doing so.
Keep the old logic will remind developers that "please remember to test the redis queue"
Since in most cases, developers only run single test, this test doesn't affect them.
And there is always a chance for developers to bypass it: CI=local make test-xxxx

I think it's better to clarify the failure message: please use "CI=local make test" if you want to run the full test but do not have a redis-server


But if most people prefer to skip the redis queue test, I have no objection.

@kdumontnu
Copy link
Contributor Author

zeripath beat me to it

@kdumontnu kdumontnu closed this May 10, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants