Fix the permission of team's Actions unit issue (#24536)
#24545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close go-gitea#24449 The unit of `Actions` should be contorlled not only by `repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED` in the `app.ini`. Previously, the permission of the team's `Actions` unit was not controlled by `actions.Enabled`. So, even if the user sets `actions.Enabled` to false, he can still select the permission of the `Actions` unit for the team. This PR makes the permissions of the team's `Actions` unit also controlled by `actions.Enabled`. Just append`TypeActions` into `DisabledRepoUnits` slice when initializing if `actions.Enabled` is false. ### Changes: If `Actions` is set disbaled in `app.ini`, like below: ```yaml [actions] ENABLED = false ``` 1. If user try to create/edit a team, will prompt user that `Actions` is disabled.  2. `actions` is not displayed in the sidebar on the team details page 
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
May 5, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 5, 2023
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24536 by @sillyguodong
close #24449
The unit of
Actionsshould be contorlled not only byrepository.DISABLED_REPO_UNITSbut also byactions.ENABLEDin the
app.ini.Previously, the permission of the team's
Actionsunit was not controlled byactions.Enabled. So, even if the user setsactions.Enabledto false, he can still select the permission of theActionsunit for the team.This PR makes the permissions of the team's
Actionsunit also controlled byactions.Enabled. Just appendTypeActionsintoDisabledRepoUnitsslice when initializing ifactions.Enabledis false.Changes:
If
Actionsis set disbaled inapp.ini, like below:Actionsis disbaled.actionsis not displayed in the sidebar on the team details page