Skip to content

Make Issue/PR/projects more compact, misc CSS tweaks #24459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
19d9288
Various CSS and HTML tweaks
silverwind May 1, 2023
8060169
issue title enhancements
silverwind May 1, 2023
e06acbe
hide 'new issue' button on pull, add margin
silverwind May 1, 2023
3d7d714
edit title enhancements
silverwind May 1, 2023
970429e
move index
silverwind May 1, 2023
50358bb
use small buttons on issue/pr, fix focus and select all
silverwind May 1, 2023
67d2e5e
remove unneeded margin
silverwind May 1, 2023
66a60ff
remove last button right margin
silverwind May 1, 2023
40fce15
fix integration
silverwind May 1, 2023
98f6557
really fix integration
silverwind May 1, 2023
d1ea7f0
style cleanup and mobile improvements
silverwind May 1, 2023
7b8e70d
padding tweak
silverwind May 1, 2023
79ee750
another padding tweak
silverwind May 1, 2023
eb06789
fix integration check
silverwind May 1, 2023
0069481
Merge branch 'main' into csstweaks28
silverwind May 1, 2023
e7c5f6b
Merge branch 'main' into csstweaks28
silverwind May 2, 2023
71014eb
rename to small-menu-items
silverwind May 2, 2023
5a4bc2b
move styles and misc tweaks
silverwind May 2, 2023
f67d75e
label tweaks and more
silverwind May 2, 2023
81a0c0f
fix branch dropdown
wxiaoguang May 3, 2023
c551d02
slight improve for align
wxiaoguang May 3, 2023
6acc168
simplify js
wxiaoguang May 3, 2023
8551bd1
remove unnecessary flex
silverwind May 3, 2023
61976e7
fix margin issue, clean up repo/issue/view.tmpl
silverwind May 3, 2023
2b755a9
move flash into view_title.tmpl
silverwind May 3, 2023
2bcfc5a
fix up commits and files tabs
silverwind May 3, 2023
95d3fea
introduce issue-title-meta, tweak issue-state-label, fix mobile paddi…
silverwind May 3, 2023
72649de
clean up a few styles
silverwind May 3, 2023
2976f3b
move description into wrapper, re-add border-radius
silverwind May 3, 2023
277c6d6
add margin for flash
silverwind May 3, 2023
ae027ce
move flash margin to flash itself
silverwind May 3, 2023
69ae142
Merge branch 'main' into csstweaks28
silverwind May 3, 2023
9a13804
Merge branch 'main' into csstweaks28
GiteaBot May 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename to small-menu-items
  • Loading branch information
silverwind committed May 2, 2023
commit 71014ebf347cce6e70f25c10799bc0c2c040c63b
2 changes: 1 addition & 1 deletion templates/projects/list.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{{end}}

{{template "base/alert" .}}
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="item{{if not .IsShowClosed}} active{{end}}" href="{{$.Link}}?state=open">
{{svg "octicon-project-symlink" 16 "gt-mr-3"}}
{{.locale.PrettyNumber .OpenCount}}&nbsp;{{.locale.Tr "repo.issues.open_title"}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/actions/openclose.tmpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="{{if not .IsShowClosed}}active {{end}}item" href="{{$.Link}}?workflow={{.CurWorkflow}}&state=open">
{{svg "octicon-issue-opened" 16 "gt-mr-3"}}
{{.locale.Tr "actions.runs.open_tab" $.NumOpenActionRuns}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/milestones.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{{template "base/alert" .}}

<div class="list-header">
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="item{{if not .IsShowClosed}} active{{end}}" href="{{.RepoLink}}/milestones?state=open&q={{$.Keyword}}">
{{svg "octicon-milestone" 16 "gt-mr-3"}}
{{.locale.PrettyNumber .OpenCount}}&nbsp;{{.locale.Tr "repo.issues.open_title"}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/issue/navbar.tmpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h2 class="ui compact small menu header small-pill-buttons">
<h2 class="ui compact small menu header small-menu-items">
<a class="{{if .PageIsLabels}}active {{end}}item" href="{{.RepoLink}}/labels">{{.locale.Tr "repo.labels"}}</a>
<a class="{{if .PageIsMilestones}}active {{end}}item" href="{{.RepoLink}}/milestones">{{.locale.Tr "repo.milestones"}}</a>
</h2>
2 changes: 1 addition & 1 deletion templates/repo/issue/openclose.tmpl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="{{if not .IsShowClosed}}active {{end}}item" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&sort={{$.SortType}}&state=open&labels={{.SelectLabels}}&milestone={{.MilestoneID}}&project={{.ProjectID}}&assignee={{.AssigneeID}}&poster={{.PosterID}}">
{{if .PageIsPullList}}
{{svg "octicon-git-pull-request" 16 "gt-mr-3"}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/projects/list.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="ui container">
<div class="navbar gt-mb-4">
<div>
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="item{{if not .IsShowClosed}} active{{end}}" href="{{.RepoLink}}/projects?state=open">
{{svg "octicon-project" 16 "gt-mr-3"}}
{{.locale.PrettyNumber .OpenCount}}&nbsp;{{.locale.Tr "repo.issues.open_title"}}
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/sub_menu_release_tag.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{$canReadCode := $.Permission.CanRead $.UnitTypeCode}}

{{if $canReadReleases}}
<h2 class="ui compact small menu header small-pill-buttons">
<h2 class="ui compact small menu header small-menu-items">
<a class="{{if .PageIsReleaseList}}active {{end}}item" href="{{.RepoLink}}/releases">{{.locale.Tr "repo.release.releases"}}</a>
{{if $canReadCode}}
<a class="{{if .PageIsTagList}}active {{end}}item" href="{{.RepoLink}}/tags">{{.locale.Tr "repo.release.tags"}}</a>
Expand Down
2 changes: 1 addition & 1 deletion templates/user/dashboard/issues.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
</div>
<div class="twelve wide column content">
<div class="list-header">
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="item{{if not .IsShowClosed}} active{{end}}" href="{{.Link}}?type={{$.ViewType}}&repos=[{{range $.RepoIDs}}{{.}}%2C{{end}}]&sort={{$.SortType}}&state=open&q={{$.Keyword}}">
{{svg "octicon-issue-opened" 16 "gt-mr-3"}}
{{.locale.PrettyNumber .IssueStats.OpenCount}}&nbsp;{{.locale.Tr "repo.issues.open_title"}}
Expand Down
2 changes: 1 addition & 1 deletion templates/user/dashboard/milestones.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</div>
<div class="twelve wide column content">
<div class="list-header">
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="item{{if not .IsShowClosed}} active{{end}}" href="{{.Link}}?repos=[{{range $.RepoIDs}}{{.}}%2C{{end}}]&sort={{$.SortType}}&state=open&q={{$.Keyword}}">
{{svg "octicon-milestone" 16 "gt-mr-3"}}
{{.locale.PrettyNumber .MilestoneStats.OpenCount}}&nbsp;{{.locale.Tr "repo.issues.open_title"}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{{if eq .Status 1}}
<div class="ui stackable grid">
<div class="six wide column">
<div class="small-pill-buttons ui compact tiny menu">
<div class="small-menu-items ui compact tiny menu">
<a class="{{if eq .State "all"}}active {{end}}item" href="{{$.Link}}?sort={{$.SortType}}&state=all&issueType={{$.IssueType}}&labels={{$.Labels}}">
{{.locale.Tr "all"}}
</a>
Expand Down
4 changes: 2 additions & 2 deletions web_src/css/repository/list-header.css
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
flex: 1;
}

.small-pill-buttons {
.small-menu-items {
min-height: 35.4px !important; /* match .small.button in height */
}

.small-pill-buttons .item {
.small-menu-items .item {
padding-top: 6px !important;
padding-bottom: 6px !important;
}