Remove Repository.getFilesChanged to fix Actions paths and paths-ignore filter (#23920)
#23969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ignore` filter (go-gitea#23920) Remove the misbehaving function and call Repository.GetFilesChangedBetween instead. Fixes go-gitea#23919 --- ~~_TODO_ test this~~ `Repository.getFilesChanged` seems to be only used by Gitea Actions, but a similar function already exists **Update** I tested this change and the issue is gone.
lunny
approved these changes
Apr 7, 2023
GiteaBot
added
the
lgtm/need 1
wolfogre
approved these changes
Apr 7, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23920 by @ChristopherHX
Remove the misbehaving function and call Repository.GetFilesChangedBetween instead.
Fixes #23919
TODO test thisRepository.getFilesChangedseems to be only used by Gitea Actions, but a similar function already existsUpdate I tested this change and the issue is gone.