Skip to content

Reduce unnecessary build on ci #23488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Reduce unnecessary build on ci #23488

wants to merge 5 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 15, 2023

There are too much build on CI. I think most of them are necessary. This PR remove unnecessary build on CI.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Mar 15, 2023
@yp05327
Copy link
Contributor

yp05327 commented Mar 15, 2023

Some steps are depends_on: [build]

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 15, 2023
@lunny
Copy link
Member Author

lunny commented Mar 15, 2023

Some steps are depends_on: [build]

fixed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 15, 2023
@silverwind
Copy link
Member 

make[1]: *** No rule to make target 'modules/public/bindata.go', needed by 'migrations.mysql.test'.  Stop.

Might need to run generate, thought I'm still hoping for #22887 to be ready so we can get rid of generate.

@lunny
Copy link
Member Author

lunny commented Apr 9, 2023

CI has been changed in other PRs, so I think this could be closed.

@lunny lunny closed this Apr 9, 2023
@lunny lunny deleted the lunny/reduce_build_ci branch April 9, 2023 08:04
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @yp05327 @silverwind @GiteaBot