Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store user projects as organization projects #23353

Merged
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f5992a7
fix incorrect project type
yp05327 Mar 7, 2023
de62b05
add db migration
yp05327 Mar 8, 2023
293a68e
fix project list page
yp05327 Mar 8, 2023
5bcc68c
(error preview)
yp05327 Mar 9, 2023
b1a471a
fix
yp05327 Mar 9, 2023
581bc03
fix lint
yp05327 Mar 10, 2023
0241dcb
Update models/migrations/v1_20/v245.go
yp05327 Mar 10, 2023
ed4214b
add session, fixme
yp05327 Mar 10, 2023
920c565
update
yp05327 Mar 14, 2023
a4c81e0
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
yp05327 Mar 14, 2023
4b26d6c
Update models/migrations/v1_20/v246.go
yp05327 Mar 14, 2023
8f5eb33
Update models/migrations/v1_20/v246.go
yp05327 Mar 14, 2023
075da0e
fix lint
yp05327 Mar 14, 2023
3bcc288
add TypeRepository as valid project type
yp05327 Mar 14, 2023
72e00b0
test: use = instead of IN
yp05327 Mar 14, 2023
41671bb
Revert "test: use = instead of IN"
yp05327 Mar 14, 2023
3d86625
update
yp05327 Mar 15, 2023
daf20f2
Revert "update"
yp05327 Mar 15, 2023
d95d35b
change 246 to 247
yp05327 Mar 15, 2023
ece905b
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
yp05327 Mar 15, 2023
cffe767
fix lint
yp05327 Mar 16, 2023
f1e0736
update
yp05327 Mar 16, 2023
2b90ac8
Revert "update"
yp05327 Mar 16, 2023
64e4395
update
yp05327 Mar 16, 2023
57e87f2
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
6543 Mar 17, 2023
795a73a
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
lunny Mar 17, 2023
55f2c0a
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
lunny Mar 17, 2023
474dfe4
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
lunny Mar 17, 2023
35e4862
Merge branch 'main' into fix-incorrect-project-type-in-user-newprojec…
lunny Mar 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions models/migrations/migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,8 @@ var migrations = []Migration{
NewMigration("Add NeedApproval to actions tables", v1_20.AddNeedApprovalToActionRun),
// v245 -> v246
NewMigration("Rename Webhook org_id to owner_id", v1_20.RenameWebhookOrgToOwner),
// v246 -> v247
NewMigration("Fix incorrect project type", v1_20.FixIncorrectProjectType),
}

// GetCurrentDBVersion returns the current db version
Expand Down
52 changes: 52 additions & 0 deletions models/migrations/v1_20/v246.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Copyright 2023 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package v1_20 //nolint

import (
"code.gitea.io/gitea/modules/log"

"xorm.io/xorm"
)

// FixIncorrectProjectType: set individual project's type from 3(TypeOrganization) to 1(TypeIndividual)
func FixIncorrectProjectType(x *xorm.Engine) error {
type User struct {
ID int64 `xorm:"pk autoincr"`
Type int
}

const (
UserTypeIndividual int = 0

TypeIndividual uint8 = 1
TypeOrganization uint8 = 3
)

type Project struct {
OwnerID int64 `xorm:"INDEX"`
Type uint8
Owner *User `xorm:"extends"`
}

sess := x.NewSession()
defer sess.Close()

if err := sess.Begin(); err != nil {
return err
}

count, err := sess.Table("project").
Where("type = ? AND owner_id = (SELECT id FROM user WHERE type = ?)", TypeOrganization, UserTypeIndividual).
yp05327 marked this conversation as resolved.
Show resolved Hide resolved
Update(&Project{
Type: TypeIndividual,
})

if err == nil {
log.Debug("Updated %d projects to belong to a user instead of an organization", count)
} else {
return err
}
yp05327 marked this conversation as resolved.
Show resolved Hide resolved

return sess.Commit()
}
2 changes: 1 addition & 1 deletion models/project/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ func TestIsProjectTypeValid(t *testing.T) {
typ Type
valid bool
}{
{TypeIndividual, false},
{TypeIndividual, true},
{TypeRepository, true},
{TypeOrganization, true},
{UnknownType, false},
Expand Down
23 changes: 18 additions & 5 deletions routers/web/org/projects.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,18 @@ func Projects(ctx *context.Context) {
page = 1
}

var projectType project_model.Type
if ctx.ContextUser.IsOrganization() {
projectType = project_model.TypeOrganization
} else {
projectType = project_model.TypeIndividual
}
projects, total, err := project_model.FindProjects(ctx, project_model.SearchOptions{
OwnerID: ctx.ContextUser.ID,
Page: page,
IsClosed: util.OptionalBoolOf(isShowClosed),
SortType: sortType,
Type: project_model.TypeOrganization,
Type: projectType,
})
if err != nil {
ctx.ServerError("FindProjects", err)
Expand All @@ -66,7 +72,7 @@ func Projects(ctx *context.Context) {
opTotal, err := project_model.CountProjects(ctx, project_model.SearchOptions{
OwnerID: ctx.ContextUser.ID,
IsClosed: util.OptionalBoolOf(!isShowClosed),
Type: project_model.TypeOrganization,
Type: projectType,
})
if err != nil {
ctx.ServerError("CountProjects", err)
Expand Down Expand Up @@ -143,14 +149,21 @@ func NewProjectPost(ctx *context.Context) {
return
}

if err := project_model.NewProject(&project_model.Project{
newProject := project_model.Project{
OwnerID: ctx.ContextUser.ID,
Title: form.Title,
Description: form.Content,
CreatorID: ctx.Doer.ID,
BoardType: form.BoardType,
Type: project_model.TypeOrganization,
}); err != nil {
}

if ctx.ContextUser.IsOrganization() {
newProject.Type = project_model.TypeOrganization
} else {
newProject.Type = project_model.TypeIndividual
}

if err := project_model.NewProject(&newProject); err != nil {
ctx.ServerError("NewProject", err)
return
}
Expand Down