Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add path prefix to ObjectStorage.Iterator #23332

Merged
merged 11 commits into from
Mar 13, 2023
Merged

add path prefix to ObjectStorage.Iterator #23332

merged 11 commits into from
Mar 13, 2023

Conversation

fuxiaohei
Copy link
Contributor

Support to iterator subdirectory in ObjectStorage for ObjectStorage.Iterator method.

It's required for #22738 to make artifact files cleanable.

@fuxiaohei fuxiaohei requested review from wolfogre and lunny March 6, 2023 12:09
wolfogre
wolfogre reviewed Mar 6, 2023
View reviewed changes
modules/storage/local.go Outdated Show resolved Hide resolved
modules/storage/local.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 6, 2023
lunny
lunny reviewed Mar 6, 2023
View reviewed changes
modules/storage/local.go Outdated Show resolved Hide resolved
@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 6, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 6, 2023
lunny
lunny reviewed Mar 8, 2023
View reviewed changes
modules/storage/local.go Outdated Show resolved Hide resolved
@wolfogre
Copy link
Member

wolfogre commented Mar 9, 2023

I think #23371 can help.

@fuxiaohei fuxiaohei force-pushed the feat/object-storage-path branch 3 times, most recently from c5b0551 to 8bfb210 Compare March 11, 2023 15:01
@codecov-commenter

This comment was marked as outdated.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2023
@lunny lunny merged commit cdc9e91 into go-gitea:main Mar 13, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fuxiaohei @wolfogre @codecov-commenter @lunny @GiteaBot