Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in the Chinese docs #23289

Merged
merged 3 commits into from
Mar 4, 2023

Conversation

anthony-zh
Copy link

@anthony-zh anthony-zh commented Mar 4, 2023

When I used docusaurus to make Chinese documents, I found that there were links on several Chinese pages with problems on docusaurus, so I modified the links on some pages and removed some useless tags

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Mar 4, 2023
@lunny lunny added this to the 1.18.6 milestone Mar 4, 2023
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 4, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 4, 2023

Wrong branch ..... or is it done by purpose?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2023
@lunny
Copy link
Member

lunny commented Mar 4, 2023

Wrong branch ..... or is it done by purpose?

Since v1.18.5 is still the latest stable version, I think we should keep the documentation available. This will fix some broken links.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2023
@delvh delvh changed the title Modify partial links of Chinese documents Fix broken links in the Chinese docs Mar 4, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2023
@lunny lunny merged commit a3e185b into go-gitea:release/v1.18 Mar 4, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2023
delvh pushed a commit that referenced this pull request Mar 4, 2023
#21627 accidentally removed the docs file `hacking-on-gitea.zh-cn.md`.
This re-adds it and merges some changes from #23289
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 4, 2023
go-gitea#21627 accidentally removed the docs file `hacking-on-gitea.zh-cn.md`.
This re-adds it and merges some changes from go-gitea#23289
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants