Skip to content

Return 404 instead of 403 if user can not access the repo #23155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Return 404 instead of 403 if user can not access the repo #23155

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4fc50
return 404 instead of 403
yp05327 Feb 26, 2023
e0e8959
Merge branch 'main' into return-404-instead-of-403-if-user-has-no-acc…
lunny Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/web/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ func httpBase(ctx *context.Context) (h *serviceHandler) {
}

if !p.CanAccess(accessMode, unitType) {
ctx.PlainText(http.StatusForbidden, "User permission denied")
ctx.PlainText(http.StatusNotFound, "Repository not found")
return
}
}
Expand Down