-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue time estimate, meaningful time tracking #23113
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you've read https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Yarden Shoham <hrsi88@gmail.com>
I suggest you remove the issue number from the title and add |
Thanks for this PR! @lunny I don't think this is duplicating existing functionality.
I see that @lafriks has posted a comment, I'm going to go read that and then come back and update my comment with how I think we should proceed. |
Can we merge these three time tracking related things into one button in the sidebar, and then show a modal. |
This! This is exactly what all this means |
I have the same idea. We need a design to include all three into the right sidebar but looks simpler. It took too much spaces currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly: the feature is good, the UI needs some new design.
I will try to make some improvements later (especially the UI part, to reduce UI complexity), maybe we could try to get this in 1.23
@lafriks the "change request" seems outdated (#23113 (review)), I think we could dismiss it. I will do some following improvements, and let's re-review again then. |
Not really, my concern was not addressed at all, currently estimate if I set a 5 days will be 24*5 hours that is not how estimates are expected in project management and this way they cannot be compared to time tracking with actual time spent to be useful. In project management when you estimate that the task requires 5 days to implement usually mean that 5 working days (5*8h or 5*7h etc depending on the company/country etc). My proposal would be to display estimate only in hours&minutes and later on implement other math behind this using org/global settings etc |
Agree, hour&minute is good enough for this feature IMO. Does anyone else have other suggestions? If no, I will do it this way. |
Update: sorry but I guess I wouldn't have enough time on this issue, recently there are many things in life that need to be dealt with so I can't promise when I would have time. Feel free to work on it if any one has time 🙏 |
) | ||
|
||
// TimeEstimateFromStr returns time estimate in seconds from formatted string | ||
func TimeEstimateFromStr(timeStr string) int64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding tests for this function would be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will work on it
This pr does:
Why?
Time estimation is essential for some teams to know the importance of issues, the amount of effort an issue would take. And for business to know if it's profitable to spend money on developers time to implement an issue
More info on https://support.atlassian.com/jira-software-cloud/docs/estimate-an-issue/#Concepts-about-estimation
Closes #23112