Refactor ctx in templates

[wxiaoguang]

Before, the dict "ctx" ... map is used to pass data between templates.

Now, more and more templates need to use real Go context:

• Fix broken pull request files #22962
• Fix nil context in RenderMarkdownToHtml #23092

ctx is a Go concept for Context, misusing it may cause problems, and it makes it difficult to review or refactor.

This PR contains 2 major changes:

• In the top scope of a template, the $ is the same as the ., so the old labels_sidebar's root is the ctx. So this ctx could just be removed. bd7f218
• Rename all other ctx to ctxData, and it perfectly matches how it comes from backend: "ctxData": ctx.Data. 7c01260

From now on, there is no ctx in templates. There are only:

• ctxData for passing data
• Context for Go context

[techknowlogick]

Marking this as breaking, normally we don't for custom templates, but marking as breaking ensures it'll be mentioned in the blog post.

[wxiaoguang]

I do not think Gitea has promised the template compatibility between releases. The "custom" document says that users should always get matched templates to customize.

If the template changes are considered to be breaking, there will be more but not only:

• Move helpers to be prefixed with gt- #22879
• Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none #22950
• ....

ps: I have no objection for marking this as breaking, as long as if helps changelog/blog.

[delvh]

What do we do about the still present PullRequestCtx?

[wxiaoguang]

What do we do about the still present PullRequestCtx?

Good point .... I didn't find it.

IMO, luckily, the PullRequestCtx is not like ctx or Context, so maybe it's fine to keep it, or rename it in the future.

[lunny]

I do think Gitea has promised the template compatibility between releases. The "custom" document says that users should always get matched templates to customize.

If the template changes are considered to be breaking, there will be more but not only:

* [Move helpers to be prefixed with `gt-` #22879](https://github.com/go-gitea/gitea/pull/22879)

* [Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none #22950](https://github.com/go-gitea/gitea/pull/22950)

* ....

ps: I have no objection for marking this as breaking, as long as if helps changelog/blog.

I would like to mark it so that users could know which templates have been changed. And I also think we could put some standards about when should break be marked in some documentation, so that maintainers could keep consistent behaviors.

[codecov-commenter]

Codecov Report

Merging #23105 (bf624ca) into main (7a5af25) will not change coverage.
The diff coverage is 66.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #23105   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files        1140     1140           
  Lines      151032   151032           
=======================================
  Hits        71816    71816           
- Misses      70712    70714    +2     
+ Partials     8504     8502    -2     

Impacted Files	Coverage Δ
routers/web/repo/issue.go	36.61% <66.66%> (ø)
modules/queue/queue_bytefifo.go	59.20% <0.00%> (-1.81%)	⬇️
modules/queue/unique_queue_disk_channel.go	64.73% <0.00%> (-1.34%)	⬇️
routers/api/packages/nuget/api_v3.go	97.24% <0.00%> (+2.75%)	⬆️
modules/charset/charset.go	75.36% <0.00%> (+3.62%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jolheiser]

🎺 🤖

[delvh]

Marking this as breaking, normally we don't for custom templates, but marking as breaking ensures it'll be mentioned in the blog post.

@techknowlogick ?

[delvh]

@techknowlogick second ping.
Why should we mention it in the blog post unlike all other template changes?