Generate small and large logos at 4x resolution #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support High-DPI displays, generate images at 4 times their displayed resolution, which should be enough to support all current devices according to https://material.io/devices/.
appleboy
approved these changes
Jul 30, 2017
|
LGTM |
bkcsoft
added
the
lgtm/need 1
lunny
added
type/enhancement
|
LGTM |
bkcsoft
added
the
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support High-DPI displays, generate the logos at 4 times their displayed resolution, which should be enough to support all current devices according to https://material.io/devices/.
This works because the CSS of Semantic UI and the
img-*classes downscale the images to correct CSS dimensions. The base dimensions of 220px and 30px of the images were chosen based on Semantic UI's.logoand.ui.mini.imagedimensions.Samples of the header image from my screen which is roughly 2 dppx, before and after: