Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deadcode #22245

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Remove deadcode #22245

merged 2 commits into from
Dec 27, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Dec 26, 2022

  • Remove code that isn't being used.

Found this is my stash from a few weeks ago, not sure how I found this in the first place.

@Gusted
Remove deadcode
a9a4706 
- Remove code that isn't being used.
delvh
delvh approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code removals are always good.
It's just a pity that two of the things that actually have tests are otherwise unused…

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2022
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Dec 27, 2022
@lunny
Copy link
Member

lunny commented Dec 27, 2022

make L-G-T-M work

@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Dec 27, 2022
@lunny lunny merged commit b48cf03 into go-gitea:main Dec 27, 2022
@Gusted Gusted deleted the remove-deadcode branch December 27, 2022 01:31
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 27, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
fa4c9e9 
* upstream/main:
  Remove deadcode (go-gitea#22245)
  Remove ReverseProxy authentication from the API (go-gitea#22219)
  Fix typo of Asia/Shanghai (go-gitea#22242)
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this pull request Dec 30, 2022
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @lunny @delvh @GiteaBot