Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round language stats percentage using largest remainder #22026

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

hr-98
Copy link
Contributor

@hr-98 hr-98 commented Dec 4, 2022

Fix #22023

I've changed how the percentages for the language statistics are rounded because they did not always add up to 100%
Now it's done with the largest remainder method, which makes sure that total is 100%

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 7, 2022
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 7, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Dec 7, 2022
@lunny
Copy link
Member

lunny commented Dec 8, 2022

Make L-G-T-M work

@lunny lunny merged commit cf27403 into go-gitea:main Dec 8, 2022
@lunny lunny added the type/bug label Dec 8, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 8, 2022
* giteaofficial/main:
  Round language stats percentage using largest remainder (go-gitea#22026)
  Support disabling database auto migration (go-gitea#22053)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language statistics percentages don't add up to 100%
5 participants