Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path not filepath in template filenames (#21993) #22022

Merged
merged 1 commit into from
Dec 4, 2022

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 3, 2022

Backport #21993

Paths in git are always separated by / not \ - therefore we should path and not filepath

Fix #21987

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#21993

Paths in git are always separated by `/` not `\` - therefore we should
`path` and not `filepath`

Fix go-gitea#21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
@zeripath zeripath added this to the 1.18.0 milestone Dec 3, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2022
@lunny lunny merged commit c7770fa into go-gitea:release/v1.18 Dec 4, 2022
@zeripath zeripath deleted the backport-21993-v1.18 branch December 4, 2022 08:45
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants