Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #21895: standardize UTC tz for translation utils #21897

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

fsologureng
Copy link
Contributor

@fsologureng fsologureng commented Nov 22, 2022

Standardize UTC timezone for translateMonth and translateDay methods.

Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be other methods to solve this but this is good enough for now I think.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 22, 2022
@lunny lunny merged commit 1d52228 into go-gitea:main Nov 22, 2022
fsologureng added a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
Standardize UTC timezone for `translateMonth` and `translateDay` tests.
@fsologureng fsologureng deleted the fix_tz_util_translate_tests branch November 22, 2022 14:20
@fsologureng fsologureng changed the title Fixes #21895: standardize UTC tz for util tests Fixes #21895: standardize UTC tz for translation utils Nov 22, 2022
@fsologureng
Copy link
Contributor Author

There may be other methods to solve this but this is good enough for now I think.

Sorry, my bad description lost focus; the problem was in the implementation, not in the testing.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 23, 2022
* giteaofficial/main:
  Handle empty author names (go-gitea#21902)
  Move all remaining colors into CSS variables (go-gitea#21903)
  Add option to enable CAPTCHA validation for login (go-gitea#21638)
  Prepend refs/heads/ to issue template refs (go-gitea#20461)
  Fixes go-gitea#21895: standardize UTC tz for util tests (go-gitea#21897)
  Clarify logging documentation (go-gitea#21665)
  Update JS dependencies (go-gitea#21881)
  Webhook list enhancements (go-gitea#21893)
  Embed Matrix icon as SVG (go-gitea#21890)
  fix(web): add `alt` for logo in home page (go-gitea#21887)
  Improvements for Content Copy (go-gitea#21842)
  Replace yaml.v2 with yaml.v3 (go-gitea#21832)
  Allow disable RSS/Atom feed (go-gitea#21622)
  Consolidate security-check into checks-backend (go-gitea#21882)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants