-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent dangling user redirects #21856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It's possible that the `user_redirect` table contains a user id that no longer exists. - Delete a user redirect upon deleting the user. - Add a check for these dangling user redirects to check-db-consistency.
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Nov 18, 2022
- Backport go-gitea#21856 - It's possible that the `user_redirect` table contains a user id that no longer exists. - Delete a user redirect upon deleting the user. - Add a check for these dangling user redirects to check-db-consistency.
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Nov 18, 2022
- Backport go-gitea#21856 - It's possible that the `user_redirect` table contains a user id that no longer exists. - Delete a user redirect upon deleting the user. - Add a check for these dangling user redirects to check-db-consistency.
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Nov 18, 2022
silverwind
approved these changes
Nov 18, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Nov 18, 2022
lunny
approved these changes
Nov 18, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Nov 18, 2022
lunny
pushed a commit
that referenced
this pull request
Nov 18, 2022
lunny
pushed a commit
that referenced
this pull request
Nov 18, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 21, 2022
* giteaofficial/main: Improve documentation for PAM and static deployment (go-gitea#21866) Add package registry cleanup rules (go-gitea#21658) Support comma-delimited string as labels in issue template (go-gitea#21831) Fix wechatwork webhook sends empty content in PR review (go-gitea#21762) Show syntax lexer name in file view/blame (go-gitea#21814) Add `context.Context` to more methods (go-gitea#21546) Timeline and color tweaks (go-gitea#21799) Fix webpack license warning (go-gitea#21815) chore: add webpack export type check (go-gitea#21857) Prevent dangling user redirects (go-gitea#21856) Fix "build from source" document to clarify the `bindata` tag is required. (go-gitea#21853) Bump loader-utils from 2.0.3 to 2.0.4 (go-gitea#21852) Do not allow Ghost access to limited visible user/org (go-gitea#21849) Fix setting HTTP headers after write (go-gitea#21833)
fsologureng
pushed a commit
to fsologureng/gitea
that referenced
this pull request
Nov 22, 2022
- It's possible that the `user_redirect` table contains a user id that no longer exists. - Delete a user redirect upon deleting the user. - Add a check for these dangling user redirects to check-db-consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_redirect
table contains a user id that no longer exists.