Skip to content

Add updated_at field to PullReview API object #21812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Add updated_at field to PullReview API object #21812

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62a3f21
Add `updated_at` field to PullReview object
yardenshoham Nov 14, 2022
614ba9f
Fix swagger docs
yardenshoham Nov 14, 2022
e0cd6bc
Merge branch 'main' into pull-review-updated-at
yardenshoham Nov 14, 2022
83014fe
Merge branch 'main' into pull-review-updated-at
lunny Nov 15, 2022
fd59d50
Merge branch 'main' into pull-review-updated-at
yardenshoham Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/convert/pull_review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func ToPullReview(ctx context.Context, r *issues_model.Review, doer *user_model.
Dismissed: r.Dismissed,
CodeCommentsCount: r.GetCodeCommentsCount(),
Submitted: r.CreatedUnix.AsTime(),
Updated: r.UpdatedUnix.AsTime(),
HTMLURL: r.HTMLURL(),
HTMLPullURL: r.Issue.HTMLURL(),
}
Expand Down
2 changes: 2 additions & 0 deletions modules/structs/pull_review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ type PullReview struct {
CodeCommentsCount int `json:"comments_count"`
// swagger:strfmt date-time
Submitted time.Time `json:"submitted_at"`
// swagger:strfmt date-time
Updated time.Time `json:"updated_at"`

HTMLURL string `json:"html_url"`
HTMLPullURL string `json:"pull_request_url"`
Expand Down
5 changes: 5 additions & 0 deletions templates/swagger/v1_json.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17888,6 +17888,11 @@
"format": "date-time",
"x-go-name": "Submitted"
},
"updated_at": {
"type": "string",
"format": "date-time",
"x-go-name": "Updated"
},
"team": {
"$ref": "#/definitions/Team"
},
Expand Down