Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to user profile in markdown mention only if user exists #21533

Merged
merged 19 commits into from
Oct 22, 2022
Merged

Add link to user profile in markdown mention only if user exists #21533

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9a2b465
Add link to user profile in markdown mention only if user exists
yardenshoham Oct 21, 2022
5b0a692
Merge branch 'main' into mention-user-exists
yardenshoham Oct 21, 2022
27dd534
Trigger build
yardenshoham Oct 21, 2022
6fb9af9
Add user to tests
yardenshoham Oct 21, 2022
459ce5b
fix test
yardenshoham Oct 21, 2022
9589e70
Merge branch 'main' into mention-user-exists
yardenshoham Oct 22, 2022
a23d5a0
Fix TestSearchUsers
yardenshoham Oct 22, 2022
d2b211e
Drop db dependency
yardenshoham Oct 22, 2022
52f4ad7
Merge remote-tracking branch 'upstream/main' into mention-user-exists
yardenshoham Oct 22, 2022
aab51ec
Fix test
yardenshoham Oct 22, 2022
f486a5f
refactor
wxiaoguang Oct 22, 2022
2368ec8
Try to fix tests
yardenshoham Oct 22, 2022
282869b
Update comment
yardenshoham Oct 22, 2022
30c9ab0
Adjust tests
yardenshoham Oct 22, 2022
2f7075d
Drop DB prep in tests
yardenshoham Oct 22, 2022
42e9e96
fix tests
wxiaoguang Oct 22, 2022
d08bc56
oops, fix the lint
wxiaoguang Oct 22, 2022
b786f0e
Merge branch 'main' into mention-user-exists
lunny Oct 22, 2022
3b7945e
Merge branch 'main' into mention-user-exists
lunny Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop db dependency 
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
  • Loading branch information
@yardenshoham
yardenshoham committed Oct 22, 2022
commit d2b211ee553149c648d74e090a18af18d36e9afb
3 changes: 1 addition & 2 deletions modules/markup/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"strings"
"sync"

"code.gitea.io/gitea/models/db"
"code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/base"
"code.gitea.io/gitea/modules/emoji"
Expand Down Expand Up @@ -608,7 +607,7 @@ func mentionProcessor(ctx *RenderContext, node *html.Node) {
mentionedUsername := mention[1:]

// Only link if the user actually exists
userExists, err := user.IsUserExist(db.DefaultContext, 0, mentionedUsername)
userExists, err := user.IsUserExist(ctx.Ctx, 0, mentionedUsername)
if err != nil {
log.Error("Failed to validate user in mention %v exists, assuming it does", mention)
userExists = true
Expand Down