Skip to content

Return 404 when user is not found on avatar #21476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Return 404 when user is not found on avatar #21476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c67bb72
Return 404 when user is not found on avatar
Oct 16, 2022
c2dba3e
Merge branch 'main' into 404-avatar-user
lunny Oct 16, 2022
2d304d6
Merge branch 'main' into 404-avatar-user
wxiaoguang Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions routers/web/user/avatar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
if strings.ToLower(userName) != "ghost" {
var err error
if user, err = user_model.GetUserByName(ctx, userName); err != nil {
if user_model.IsErrUserNotExist(err) {
ctx.NotFound("GetUserByName", err)
return
}
ctx.ServerError("Invalid user: "+userName, err)
return
}
Expand Down