Add Num{Issues,Pulls} stats checks #21404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Currently `repository.Num{Issues,Pulls}` weren't checked and could
become out-of-consistency. Adds these two checks to `CheckRepoStats`.
- Fix incorrect SQL query for `repository.NumClosedPulls`, the check
should be for `repo_num_pulls`.
- Reference: https://codeberg.org/Codeberg/Community/issues/696
lafriks
approved these changes
Oct 10, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Oct 10, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Oct 10, 2022
Codecov Report
@@ Coverage Diff @@
## main #21404 +/- ##
=======================================
Coverage ? 47.42%
=======================================
Files ? 1020
Lines ? 139019
Branches ? 0
=======================================
Hits ? 65935
Misses ? 65093
Partials ? 7991
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Oct 11, 2022
- Backport go-gitea#21404 - Currently `repository.Num{Issues,Pulls}` weren't checked and could become out-of-consistency. Adds these two checks to `CheckRepoStats`. - Fix incorrect SQL query for `repository.NumClosedPulls`, the check should be for `repo_num_pulls`. - Reference: https://codeberg.org/Codeberg/Community/issues/696
wxiaoguang
added a commit
that referenced
this pull request
Oct 12, 2022
Backport #21404 Currently `repository.Num{Issues,Pulls}` weren't checked and could become out-of-consistency. Adds these two checks to `CheckRepoStats`. Fix incorrect SQL query for `repository.NumClosedPulls`, the check should be for `repo_num_pulls`. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
tyroneyeh
pushed a commit
to tyroneyeh/gitea
that referenced
this pull request
Oct 24, 2022
Backport go-gitea#21404 Currently `repository.Num{Issues,Pulls}` weren't checked and could become out-of-consistency. Adds these two checks to `CheckRepoStats`. Fix incorrect SQL query for `repository.NumClosedPulls`, the check should be for `repo_num_pulls`. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repository.Num{Issues,Pulls}weren't checked and could become out-of-consistency. Adds these two checks toCheckRepoStats.repository.NumClosedPulls, the check should be forrepo_num_pulls.