Fix linked account translation #21331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
delvh
approved these changes
Oct 4, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Oct 4, 2022
GiteaBot
added
lgtm/done
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Oct 4, 2022
fix key used for translation Signed-off-by: jolheiser <john.olheiser@gmail.com>
techknowlogick
pushed a commit
that referenced
this pull request
Oct 5, 2022
tyroneyeh
added a commit
to tyroneyeh/gitea
that referenced
this pull request
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21318
Going back, I couldn't find a previous value that matches this, my guess is it was simply overlooked. Our previous
i18ncode would have set this to the final key, which isactiveLo and behold,
The above is from codeberg, but I can confirm on my own instance as well.
Now, I've gone and used
repo.settings.active, which is arguably for webhooks.gitea/options/locale/locale_en-US.ini
Lines 1998 to 1999 in 274523b
Given it's a single word, I think it's fine to re-use, but I'm open to making a new key if that's preferred.