Use POSIX complaint ! operator in find #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-not is a GNU extension and not all find(8) implementations support it. It's just an alias for ! which is POSIX compliant. Now gitea compiles on NetBSD at least.
lafriks
requested changes
Jul 9, 2017
vendor/code.gitea.io/git/Makefile
Outdated
| @@ -18,7 +18,7 @@ generate: | |||
|
|
|||
| .PHONY: fmt | |||
| fmt: | |||
| find . -name "*.go" -type f -not -path "./vendor/*" -not -path "./benchmark/*" | xargs gofmt -s -w | |||
| find . -name "*.go" -type f ! -path "./vendor/*" ! -path "./benchmark/*" | xargs gofmt -s -w | |||
There was a problem hiding this comment.
Do not make changes to vendor directory. Create PR in github.com/go-gitea/git/ repository for this change
|
What @lafriks said, vendored files are changed upstream :) https://github.com/go-gitea/git/ in this case |
tboerger
added
the
lgtm/need 2
|
@bkcsoft why did you close PR, there was also gitea Makefile changes that are ok here? |
lafriks
approved these changes
Jul 9, 2017
|
Ooh, must've missed that one. Sorry 😅 |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
- Unset the http proxies environments for the `TestWebhookProxy`. - Resolves go-gitea#2132 (cherry picked from commit 244b9786fc431c362c6f5ac971ac4d04b97f78a2) (cherry picked from commit 8602dfa6a21e1ac9fa0fc6f5952da219a57b2613) (cherry picked from commit 862144920945575c26e026281aab6e9bf3e00c5c) (cherry picked from commit aefa77f917b58dc9e3fc013790aaa286f0beda5b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-not is a GNU extension and not all find(8) implementations
support it. It's just an alias for ! which is POSIX compliant.
Now gitea compiles on NetBSD at least.