Skip to content

Make NuGet service index publicly accessible (#21242) #21277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 8, 2022
Merged

Make NuGet service index publicly accessible (#21242) #21277

merged 5 commits into from
Oct 8, 2022

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 27, 2022

Backport of #21242

@KN4CK3R @wxiaoguang
Make NuGet service index publicly accessible (go-gitea#21242)
5bb0980 
Addition to go-gitea#20734, Fixes go-gitea#20717

The `/index.json` endpoint needs to be accessible even if the registry
is private. The NuGet client uses this endpoint without
authentification.

The old fix only works if the NuGet cli is used with `--source <name>`
but not with `--source <url>/index.json`.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@KN4CK3R KN4CK3R added this to the 1.17.3 milestone Sep 27, 2022
@lafriks
Copy link
Member

lafriks commented Sep 27, 2022 

integrations/api_packages_nuget_test.go:76:17: privateUser.Name undefined (type interface{} has no field or method Name) (typecheck)
			{privateUser.Name, false, false},
			             ^
integrations/api_packages_nuget_test.go:77:17: privateUser.Name undefined (type interface{} has no field or method Name) (typecheck)
			{privateUser.Name, true, false},
			             ^
integrations/api_packages_nuget_test.go:78:17: privateUser.Name undefined (type interface{} has no field or method Name) (typecheck)
			{privateUser.Name, false, true},

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 27, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2022
@zeripath
Copy link
Contributor

zeripath commented Oct 8, 2022

Make lgtm work

@zeripath zeripath merged commit a3c75ac into go-gitea:release/v1.17 Oct 8, 2022
@KN4CK3R KN4CK3R deleted the backport-0c8ce71 branch October 10, 2022 13:17
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
@tyroneyeh @wxiaoguang @6543
Make NuGet service index publicly accessible (go-gitea#21242) (go-git…
270aa01 
…ea#21277)

Backport of go-gitea#21242

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug

Projects

None yet

Milestone

1.17.3

Development

Successfully merging this pull request may close these issues.

6 participants

@KN4CK3R @lafriks @zeripath @wxiaoguang @GiteaBot @6543