Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various CSS tweaks #21244

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Various CSS tweaks #21244

merged 2 commits into from
Sep 23, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 22, 2022 •
edited
Loading

  • Remove arc-green specific rules and instead fix the colors in the base rules.
  • Make file table row border visible on arc-green.
  • Remove remnants of fomantic accordeon module that was removed.

This introduces 1 new CSS var, which is breaking for theme authors.

Screen Shot 2022-09-22 at 22 15 39

Screen Shot 2022-09-22 at 23 11 07

Screen Shot 2022-09-22 at 23 11 40

@silverwind
Various CSS tweaks
5621b02 
- Remove arc-green specific rules and instead fix the colors in the base
  rules.
- Make file table row border visible on arc-green.
- Remove remnants of fomantic accordeon module that was removed.
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 22, 2022
@silverwind silverwind added this to the 1.18.0 milestone Sep 22, 2022
@silverwind silverwind added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 22, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 22, 2022
@silverwind silverwind removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Sep 22, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 23, 2022
@jolheiser jolheiser merged commit 3f9e323 into go-gitea:main Sep 23, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 23, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
7636631 
* upstream/main:
  Various CSS tweaks (go-gitea#21244)
  [skip ci] Updated translations via Crowdin
@silverwind silverwind deleted the csstweaks23 branch September 23, 2022 04:45
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @wxiaoguang @jolheiser @GiteaBot