Prevent invalid behavior for file reviewing when loading more files (#21230) #21234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#21230) The problem was that many PR review components loaded by `Show more` received the same ID as previous batches, which confuses browsers (when clicked). All such occurrences should now be fixed. Additionally improved the background of the `viewed` checkbox. Lastly, the `go-licenses.json` was automatically updated. Fixes go-gitea#21228. Fixes go-gitea#20681. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
delvh
changed the title
delvh
changed the title
KN4CK3R
approved these changes
Sep 21, 2022
GiteaBot
added
the
lgtm/need 1
wxiaoguang
reviewed
Sep 22, 2022
silverwind
approved these changes
Sep 22, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21230
The problem was that many PR review components loaded by
Show morereceived the same ID as previous batches, which confuses browsers (when clicked). All such occurrences should now be fixed.Additionally improved the background of the
viewedcheckbox.Fixes #21228.
Fixes #20681.
Co-authored-by: wxiaoguang wxiaoguang@gmail.com