-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mirror address setting not working #20850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
backport/v1.17
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Aug 19, 2022
lunny
approved these changes
Aug 19, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Aug 19, 2022
Gusted
approved these changes
Aug 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar behavior/checks how we do this in API for mirror management. As for integration testing you want to look at integrations/mirror_push-test.go
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 20, 2022
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Aug 21, 2022
Backport go-gitea#20850 This patch fixes the issue that the mirror address field is ignored from the repo setting form.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2022
* giteaofficial/main: update current stable version [skip ci] Updated translations via Crowdin Fix mirror address setting not working (go-gitea#20850) Support Proxy protocol (go-gitea#12527) Fix SQL Query for `SearchTeam` (go-gitea#20844) Double check CloneURL is acceptable (go-gitea#20869) Fix graceful doc (go-gitea#20883) Pad GPG Key ID with preceding zeroes (go-gitea#20878) [skip ci] Updated translations via Crowdin call builtinUnused() if internal SSH is disabled (go-gitea#20877) Don't open new page for ext wiki on same repository (go-gitea#20725) [skip ci] Updated translations via Crowdin Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861) Fix UI mis-align for PR commit history (go-gitea#20845)
techknowlogick
pushed a commit
that referenced
this pull request
Aug 23, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
This patch fixes the issue that the mirror address field is ignored from the repo setting form.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue that the mirror address field is ignored from the repo setting form. This patch needs to be cherry-picked to 1.17.x maintain branch.
It'll be good if someone can help by adding an integration test for this issue :)