-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement Issue forms #20778
WIP: Implement Issue forms #20778
Conversation
Hmm, I cannot reproduce the "Imports are sorted wrong" lint error on my side, and I can't find a tool that reorders differently them from what they are currently. |
81992c7
to
76ad295
Compare
Codecov Report
@@ Coverage Diff @@
## main #20778 +/- ##
==========================================
- Coverage 47.01% 47.00% -0.01%
==========================================
Files 982 983 +1
Lines 136101 136231 +130
==========================================
+ Hits 63989 64040 +51
- Misses 64250 64331 +81
+ Partials 7862 7860 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…rkdown template parse errors be hard errors
39852f1
to
532fa06
Compare
I chose to show it in the chooser since the form may be broken and I wouldn't want users to submit a broken form (because they will ignore the error) so I hide any form template with errors. |
Since #20987 merged, this PR could be rebased. |
Or closed? |
I'll close this and open a new PR for any other enhancements :) |
Implements #20232.
There's no dev-facing API for this feature, it's pretty much all GUI.
This is my first time writing Go beyond 10 lines of code, look for beginner mistakes :)
Screenshots:
Click to expand
#### Choose template ![2022-08-13 04 40 34 localhost d13ea5841a5e](https://user-images.githubusercontent.com/6624767/184463795-bb227f1f-d142-49d1-81c1-2d7fbe21c6c7.png)Form
Result
Features:
Multi-select dropdowns-> replaced with checkboxes in the meantimeAuto-Assign people based on template-> Need to be done for md templates as well, out of scopePR form templates-> out of scope for this PRGraphical issue builder-> laterconfig.yml
blank_issues_enabled: false
Known issues:
Tabindex is broken (cannot tab between fields)Fixed