Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop logging EOFs and exit(1)s in ssh handler (#20476) #20529

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Stop logging EOFs and exit(1)s in ssh handler (#20476) #20529

merged 2 commits into from
Jul 29, 2022

Commits on Jul 28, 2022

  1. Stop logging EOFs and exit(1)s in ssh handler (go-gitea#20476) 

    Backport go-gitea#20476

The code in modules/ssh/ssh.go:sessionHandler() currently cause an error to be
logged if `gitea serv` exits with a exit(1). This logging is useless because the
accompanying stderr is not provided and in any case the exit(1) is most likely due
to permissions errors.

Further it then causes the EOF to be logged - even though this is not helpful.

This PR simply checks the errors returned and stops logging them.

In the case of misconfigurations causing `gitea serv` to fail with exit(1)
the current logging is not helpful at determining this and users should simply
review the message passed over the ssh connection.

Fix go-gitea#20473

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    f0e9c61 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release/v1.17' into backport-20476-v1.17

    @6543
    6543 authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    deb364b View commit details
    Browse the repository at this point in the history