Skip to content

Conversation

@ethantkoenig
Copy link
Member

Fix bug in POST /repos/:owner/:repo/issues/:index/labels and PUT /repos/:owner/:repo/issues/:index/labels endpoints. Also add integration tests for those endpoints.

@lafriks
Copy link
Member

lafriks commented Jun 24, 2017

make fmt fails and needs to be fixed otherwise looks good

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 24, 2017
@ethantkoenig ethantkoenig force-pushed the fix/issue_labels_api branch from 12ba09f to 0968a3d Compare June 24, 2017 17:41
@ethantkoenig
Copy link
Member Author

gofmt fixed

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2017
@appleboy appleboy added this to the 1.2.0 milestone Jun 24, 2017
@pgaskin
Copy link
Contributor

pgaskin commented Jun 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2017
@lunny lunny merged commit 3ffedea into go-gitea:master Jun 24, 2017
@ethantkoenig ethantkoenig deleted the fix/issue_labels_api branch June 25, 2017 02:29
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants