Skip to content

Changed colors of delete-modal #20212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mawoka-myblock
Copy link

The "Confirm"-Delete button is now red and the cancel-button green.


The colors of the buttons in the delete-modal are swapped, so that the cancel-button is now green and the confirm-button is now red.

The "Confirm"-Delete button is now red and the cancel-button green.
@a1012112796 a1012112796 added the topic/ui Change the appearance of the Gitea UI label Jul 3, 2022
@delvh
Copy link
Member

delvh commented Jul 3, 2022

Could you please paste a screenshot how it looks like now?
Because while I can generally guess how it would look like, it most likely won't hurt to see it visualized.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 3, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jul 4, 2022
@mawoka-myblock
Copy link
Author

Old

Nein_alt
Ja_alt

New

Nein_neu
Ja_neu

@mawoka-myblock
Copy link
Author

Any updates @delvh ?

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I can absolutely see this change.
The only problem: There are currently many self-built delete modals inside the templates:
Simply search for delete modal inside files in the templates folder, and you'll see what I mean.
And those other modals all have the previous behavior.

Due to the complexity introduced by Go templates, they likely won't be converted into calls of this template for quite some time.
So, they should be adapted then as well.

@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Feb 3, 2023
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 25, 2023

Now we have a totally new "modal button" system. #24289

The "negative" button could never be "green" anymore.

But there are still many modal buttons do not have consistent colors, eg: some "confirm to delete" buttons are yellow, some are green.

@mawoka-myblock
Copy link
Author

Then this pr isn't needed anymore

@GiteaBot GiteaBot removed this from the 1.20.0 milestone Apr 25, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants