-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Changed colors of delete-modal #20212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The "Confirm"-Delete button is now red and the cancel-button green.
Could you please paste a screenshot how it looks like now? |
Any updates @delvh ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I can absolutely see this change.
The only problem: There are currently many self-built delete modals inside the templates:
Simply search for delete modal
inside files in the templates folder, and you'll see what I mean.
And those other modals all have the previous behavior.
Due to the complexity introduced by Go templates, they likely won't be converted into calls of this template for quite some time.
So, they should be adapted then as well.
Now we have a totally new "modal button" system. #24289 The "negative" button could never be "green" anymore. But there are still many modal buttons do not have consistent colors, eg: some "confirm to delete" buttons are yellow, some are green. |
Then this pr isn't needed anymore |
The "Confirm"-Delete button is now red and the cancel-button green.
The colors of the buttons in the delete-modal are swapped, so that the cancel-button is now green and the confirm-button is now red.