Skip to content

Add username check to doctor #20140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2022
Merged

Add username check to doctor #20140

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc966ff
Add username check to doctor
Jun 26, 2022
2c380e4
Fix extra argument
Jun 26, 2022
03d06f8
Apply suggestions from code review
Jun 26, 2022
825a5b7
Merge branch 'main' into add-breaking-username-check
jolheiser Jun 27, 2022
b9aa6d0
Merge branch 'main' into add-breaking-username-check
jolheiser Jun 27, 2022
b37187f
Apply suggestions from code review
techknowlogick Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix extra argument
  • Loading branch information
Gusted committed Jun 26, 2022
commit 2c380e44abc92bc07719a60286039e933382024c
2 changes: 1 addition & 1 deletion modules/doctor/breaking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func checkUserName(ctx context.Context, logger log.Logger, _ bool) error {
if err := iterateUserAccounts(ctx, func(u *user.User) error {
if err := user.IsUsableUsername(u.Name); err != nil {
invalidUserCount++
logger.Warn("User[id=%d] have not a valid username: %v", u.ID, u.Name, err)
logger.Warn("User[id=%d] have not a valid username: %v", u.ID, err)
}
return nil
}); err != nil {
Expand Down