Skip to content

Improve valid user name check #20136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 4, 2022
Merged

Improve valid user name check #20136

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0f5c5ee
Improve valid user name check
wxiaoguang Jun 25, 2022
70fe59a
fix lint
wxiaoguang Jun 26, 2022
edab085
Merge branch 'main' into improve-valid-username
wxiaoguang Jun 27, 2022
54c673b
move valid username regexp to user model, fix tests
wxiaoguang Jun 27, 2022
4b624c7
fix fmt
wxiaoguang Jun 27, 2022
94d79ce
fix more checks
wxiaoguang Jun 27, 2022
4a35fec
Merge branch 'main' into improve-valid-username
wolfogre Nov 1, 2022
b203f62
feat: update username check
wolfogre Nov 1, 2022
138a2b5
chore: use old rule for repo name
wolfogre Nov 1, 2022
d2f2ba1
feat: add new validation rule
wolfogre Nov 1, 2022
0bcd62f
test: update integration tests
wolfogre Nov 1, 2022
2f72fd5
fix: update more form validations
wolfogre Nov 1, 2022
0ba8593
test: check new error message
wolfogre Nov 1, 2022
2e82b61
Merge branch 'main' into improve-valid-username
lunny Nov 2, 2022
6bcde7b
Merge branch 'main' into improve-valid-username
wolfogre Nov 3, 2022
e957aa1
Merge branch 'main' into improve-valid-username
lunny Nov 3, 2022
5ef6c02
Update modules/validation/helpers.go
wolfogre Nov 4, 2022
1f53ec0
test: add more cases
wolfogre Nov 4, 2022
f61c613
fix: update username error
wolfogre Nov 4, 2022
e0506f5
Merge branch 'main' into improve-valid-username
wolfogre Nov 4, 2022
8f904dd
test: add more cases
wolfogre Nov 4, 2022
4ffb9c8
chore: fmt
wolfogre Nov 4, 2022
a5eac54
chore: trigger CI
wolfogre Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add more cases
  • Loading branch information
@wolfogre
wolfogre committed Nov 4, 2022
commit 1f53ec0d81e9d54c355a004a5fb65c4eabc2438c
4 changes: 4 additions & 0 deletions modules/validation/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ func TestIsValidUsername(t *testing.T) {
{arg: "a_-bc", want: false},
{arg: "a/bc", want: false},
{arg: "☁️", want: false},
{arg: "-", want: false},
{arg: "--diff", want: false},
{arg: "-im-here", want: false},
{arg: "a space", want: false},
}
for _, tt := range tests {
t.Run(tt.arg, func(t *testing.T) {
Expand Down