-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respond with a 401 on git push when password isn't changed yet (#20026) #20027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#19090 If the user-agent starts with git and user must change password but hasn't return a 401 with the message. It must be a 401, git doesn't seem to show the contents of the error message when we return a 403
@42wim please target the right branch |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jun 18, 2022
6543
changed the title
Respond with a 401 on git push when password isn't changed yet
Respond with a 401 on git push when password isn't changed yet (#20026)
Jun 18, 2022
whoops |
6543
approved these changes
Jun 18, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jun 18, 2022
delvh
approved these changes
Jun 18, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jun 18, 2022
lafriks
approved these changes
Jun 19, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 20, 2022
* giteaofficial/release/v1.17: (35 commits) Simplify and fix migration 216 (go-gitea#20036) Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) (go-gitea#20041) Backtick table name in generic orphan check (go-gitea#20019) (go-gitea#20037) Respond with a 401 on git push when password isn't changed yet (go-gitea#20027) Fix delete pull head ref for DeleteIssue (go-gitea#20032) (go-gitea#20034) use quoted regexp instead of git fixed-value (go-gitea#20030) Dump should only copy regular files and symlink regular files (go-gitea#20015) (go-gitea#20021) Return 404 when tag is broken (go-gitea#20024) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Add fgprof pprof profiler (go-gitea#20005) [skip ci] Updated translations via Crowdin Improve action table indices (go-gitea#19472) Add dbconsistency checks for Stopwatches (go-gitea#20010) fix push mirrors URL are no longer displayed on the UI (go-gitea#20011) Empty log queue on flush and close (go-gitea#19994) [skip ci] Updated translations via Crowdin Stop spurious APIFormat stopwatches logs (go-gitea#20008) Fix CountOrphanedLabels in orphan check (go-gitea#20009) Write Commit-Graphs in RepositoryDumper (go-gitea#20004) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #20026
If the user-agent starts with git and user must change password but
hasn't return a 401 with the message.
It must be a 401, git doesn't seem to show the contents of the error message
when we return a 403