Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tab/TabName usage where it's not needed #19973

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jun 15, 2022

tab query argument and TabName in context is used only in profile so remove it from all other places where it's not used anymore.

@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 15, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 15, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2022
@Gusted Gusted added this to the 1.17.0 milestone Jun 15, 2022
@wxiaoguang

This comment was marked as outdated.

Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this PR could be correct.

The SetDefaultParams also read the TabName from context data. Now it's refactored, so no problem

templates/explore/code.tmpl Show resolved Hide resolved
@wxiaoguang wxiaoguang merged commit 1f8f9c3 into go-gitea:main Jun 15, 2022
@wxiaoguang wxiaoguang changed the title Remove tab/TabPage usage where it's not needed Remove tab/TabName usage where it's not needed Jun 15, 2022
@lafriks lafriks deleted the feat/refactor_tabname branch June 15, 2022 15:11
@lafriks lafriks changed the title Remove tab/TabName usage where it's not needed Remove tab/TabPage usage where it's not needed Jun 15, 2022
@wxiaoguang
Copy link
Contributor

Sorry for bothering, but the code symbol is TabName, not TabPage, what does TabPage refer to? Did I misunderstand something ....

@lafriks lafriks changed the title Remove tab/TabPage usage where it's not needed Remove tab/TabName usage where it's not needed Jun 15, 2022
@lafriks
Copy link
Member Author

lafriks commented Jun 15, 2022

Yes I just fixed in wrong place, I had wrong name in description but I changed to wrong in title 😆

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 16, 2022
* giteaofficial/main:
  Allow render HTML with css/js external links (go-gitea#19017)
  Use correct count for `NumOpenIssues` (go-gitea#19980)
  In code search, get code unit accessible repos in one (main) query (go-gitea#19764)
  [skip ci] Updated translations via Crowdin
  Always try to fetch repo for mirrors (go-gitea#19975)
  Remove tab/TabName usage where it's not needed (go-gitea#19973)
  Fix cli command restore-repo: "units" should be parsed as StringSlice (go-gitea#19953)
  Uppercase first languages letters (go-gitea#19965)
  Move tests as seperate sub packages to reduce duplicated file names (go-gitea#19951)
  Replace unstyled meter with progress (go-gitea#19968)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Remove singuliere from MAINTAINERS (go-gitea#19883)
  Fix aria for logo (go-gitea#19955)
  Fix mirror template bug (go-gitea#19959)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
`tab` query argument and `TabName` in context is used only in profile so remove it from all other places where it's not used anymore.
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
`tab` query argument and `TabName` in context is used only in profile so remove it from all other places where it's not used anymore.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants